szaszm commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553850276
########## File path: libminifi/include/utils/ProcessorConfigUtils.h ########## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <vector> +#include <string> + +#include "utils/StringUtils.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace utils { + +std::string getRequiredPropertyOrThrow(const core::ProcessContext* context, const std::string& property_name) { + std::string value; + if (!context->getProperty(property_name, value)) { + throw Exception(PROCESS_SCHEDULE_EXCEPTION, property_name + " property missing or invalid"); + } + return value; +} + +std::vector<std::string> listFromCommaSeparatedProperty(const core::ProcessContext* context, const std::string& property_name) { + std::string property_string; + context->getProperty(property_name, property_string); + return utils::StringUtils::splitAndTrim(property_string, ","); +} + +std::vector<std::string> listFromRequiredCommaSeparatedProperty(const core::ProcessContext* context, const std::string& property_name) { + return utils::StringUtils::splitAndTrim(getRequiredPropertyOrThrow(context, property_name), ","); +} + +bool parseBooleanPropertyOrThrow(core::ProcessContext* context, const std::string& property_name) { + bool value; + std::string value_str = getRequiredPropertyOrThrow(context, property_name); + utils::optional<bool> maybe_value = utils::StringUtils::toBool(value_str); + if (!maybe_value) { + throw Exception(PROCESS_SCHEDULE_EXCEPTION, property_name + " property is invalid: value is " + value_str); Review comment: I'm fine with `std::runtime_error` or `std::invalid_argument` as well, but I don't want miscategorized exceptions. ########## File path: extensions/librdkafka/rdkafka_utils.cpp ########## @@ -0,0 +1,115 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include <array> + +#include "rdkafka_utils.h" + +#include "Exception.h" +#include "utils/StringUtils.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace utils { + +void setKafkaConfigurationField(rd_kafka_conf_t* configuration, const std::string& field_name, const std::string& value) { + static std::array<char, 512U> errstr{}; + rd_kafka_conf_res_t result; + result = rd_kafka_conf_set(configuration, field_name.c_str(), value.c_str(), errstr.data(), errstr.size()); + if (RD_KAFKA_CONF_OK != result) { + const std::string error_msg { errstr.begin(), errstr.end() }; + throw Exception(PROCESS_SCHEDULE_EXCEPTION, "rd_kafka configuration error" + error_msg); + } +} + +void print_topics_list(std::shared_ptr<logging::Logger> logger, rd_kafka_topic_partition_list_t* kf_topic_partition_list) { + for (std::size_t i = 0; i < kf_topic_partition_list->cnt; ++i) { + logger->log_debug("kf_topic_partition_list: topic: %s, partition: %d, offset:%lld]", + kf_topic_partition_list->elems[i].topic, kf_topic_partition_list->elems[i].partition, kf_topic_partition_list->elems[i].offset); + } +} + +void print_kafka_message(const rd_kafka_message_t* rkmessage, const std::shared_ptr<logging::Logger>& logger) { Review comment: Taking a shared pointer instead of an observer pointer/reference makes it impossible to use the function with anything other than a shared pointer, like unique ptr, stack object, manually allocated or member of another object. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
