szaszm commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r576730170
##########
File path: libminifi/test/TestBase.cpp
##########
@@ -111,28 +109,19 @@ std::shared_ptr<core::Processor>
TestPlan::addProcessor(const std::shared_ptr<co
}
relationships_.push_back(connection);
}
-
std::shared_ptr<core::ProcessorNode> node =
std::make_shared<core::ProcessorNode>(processor);
-
processor_nodes_.push_back(node);
-
// std::shared_ptr<core::ProcessContext> context =
std::make_shared<core::ProcessContext>(node, controller_services_provider_,
prov_repo_, flow_repo_, configuration_, content_repo_);
-
auto contextBuilder =
core::ClassLoader::getDefaultClassLoader().instantiate<core::ProcessContextBuilder>("ProcessContextBuilder");
-
contextBuilder =
contextBuilder->withContentRepository(content_repo_)->withFlowFileRepository(flow_repo_)->withProvider(controller_services_provider_.get())->withProvenanceRepository(prov_repo_)->withConfiguration(configuration_);
-
auto context = contextBuilder->build(node);
-
processor_contexts_.push_back(context);
-
processor_queue_.push_back(processor);
-
return processor;
}
std::shared_ptr<core::Processor> TestPlan::addProcessor(const std::string
&processor_name, const utils::Identifier& uuid, const std::string &name,
- const
std::initializer_list<core::Relationship>& relationships, bool linkToPrevious) {
+ const std::initializer_list<core::Relationship>& relationships, bool
linkToPrevious) {
Review comment:
Continuation indentation should be 4 spaces or aligned. My preference is
4 spaces, the style guide's is aligned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
