adamdebreceni commented on a change in pull request #1005:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1005#discussion_r577506574
##########
File path: bootstrap.sh
##########
@@ -318,14 +315,16 @@ add_dependency TENSORFLOW_ENABLED "tensorflow"
add_disabled_option OPC_ENABLED ${FALSE} "ENABLE_OPC"
add_dependency OPC_ENABLED "mbedtls"
+JNI_ENABLED=${FALSE}
+add_dependency JNI_ENABLED "jnibuild"
Review comment:
it seems to me, that `JNI_ENABLED` no longer being added to `OPTIONS`
affects the platform specific dependency installer scripts, specifically they
iterate over the `OPTIONS` and then install their dependencies, could this
cause that java will no longer be installed even if we enable jni?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
