fgerlits commented on a change in pull request #1005:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1005#discussion_r579051480
##########
File path: bootstrap.sh
##########
@@ -320,12 +320,11 @@ add_dependency OPC_ENABLED "mbedtls"
USE_SHARED_LIBS=${TRUE}
TESTS_DISABLED=${FALSE}
+ASAN_ENABLED=${FALSE}
## name, default, values
add_multi_option BUILD_PROFILE "RelWithDebInfo" "RelWithDebInfo" "Debug"
"MinSizeRel" "Release"
-add_disabled_option ASAN_ENABLED ${FALSE} "ASAN_BUILD"
Review comment:
Indeed, it was missing from `bt_state`. Fixed in
https://github.com/apache/nifi-minifi-cpp/pull/1005/commits/28970606a01063e4491bbb35ca4de5899e1cd865.
This bootstrap script is a bit of a mess, and should be refactored, but I
think that should be done in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
