fgerlits commented on pull request #992: URL: https://github.com/apache/nifi-minifi-cpp/pull/992#issuecomment-780655750
Yes, using (a modified or extended version of) ConcurrentQueue [rather than exposing the internal mutex and deque and using those] would require some refactoring of the Connection class. That is not necessarily a bad thing, as `Connection::poll()` contains some duplicated code. I also can't see a way to avoid some performance degradation, as you mentioned. But I don't think that is a big problem, as the difference in performance would be small. To be honest, at this point I would vote for keeping the old code as it was, but let's see what other people say. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
