hunyadi-dev commented on a change in pull request #992:
URL: https://github.com/apache/nifi-minifi-cpp/pull/992#discussion_r579201725
##########
File path: libminifi/include/utils/MinifiConcurrentQueue.h
##########
@@ -87,6 +91,10 @@ class ConcurrentQueue {
queue_.emplace_back(std::forward<Args>(args)...);
}
+ LockedConcurrentQueue<T> lock() {
Review comment:
Why would you do this? If you really want to extend the functionality of
the class, instead of adding friend accessors, make your queue inherit from the
`ConcurrentQueue`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
