hunyadi-dev commented on a change in pull request #992:
URL: https://github.com/apache/nifi-minifi-cpp/pull/992#discussion_r579212715
##########
File path: libminifi/src/Connection.cpp
##########
@@ -157,15 +149,15 @@ void Connection::put(const
std::shared_ptr<core::FlowFile>& flow) {
void Connection::multiPut(std::vector<std::shared_ptr<core::FlowFile>>& flows)
{
{
- std::lock_guard<std::mutex> lock(mutex_);
+ auto lockedQueue = queue_.lock();
Review comment:
Instead of this, I would create an interface on the queue that performs
batch insertion. This piece of API could be better tested as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
