factoryexception commented on a change in pull request #4852:
URL: https://github.com/apache/nifi/pull/4852#discussion_r585271520
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestListenTCP.java
##########
@@ -156,7 +156,7 @@ public void
testTLSClientAuthRequiredAndClientCertNotProvided() throws Initializ
messages.add("This is message 5\n");
// Make an SSLContext that only has the trust store, this should not
work since the processor has client auth REQUIRED
- Assert.assertThrows(SSLException.class, () ->
Review comment:
This is a subtle change that works differently based on the specific
update revision of Java 8. More recent versions, after Update 271 in general,
should throw an `SSLException` whereas older versions will throw an
IOException. Did you get a test failure? The recent GitHub CI checks failed
with a Checkstyle violation due to the unused import of `SSLException`. Since
`SSLException` is a subclass of `IOException`, your change to the more general
exception seems like the better way to go, just remove the unused import and
that should work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
