markap14 commented on a change in pull request #4852:
URL: https://github.com/apache/nifi/pull/4852#discussion_r589618885
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-utils/src/main/java/org/apache/nifi/nar/StandardExtensionDiscoveringManager.java
##########
@@ -128,7 +131,11 @@ public void discoverExtensions(final Set<Bundle>
narBundles) {
// so that static initialization techniques that depend on the
context class loader will work properly
final ClassLoader ncl = bundle.getClassLoader();
Thread.currentThread().setContextClassLoader(ncl);
+
+ final long loadStart = System.currentTimeMillis();
loadExtensions(bundle);
+ final long loadMillis = System.currentTimeMillis() - loadStart;
+ logger.info("Loaded extensions for {} in {} millis",
bundle.getBundleDetails(), loadMillis);
Review comment:
I did consider moving that down to DEBUG level. But I think it makes
more sense at INFO level. It is verbose, yes. But it's only on startup, and can
be good info to have, as a long load time would indicate that something may be
problematic. Plus, it was certainly convenient for measuring timing before &
after the change. But I am ok decreasing to DEBUG if you think it would be
annoying in the logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
