fgerlits opened a new pull request #1037: URL: https://github.com/apache/nifi-minifi-cpp/pull/1037
https://issues.apache.org/jira/browse/MINIFICPP-1520 Contains the following fixes: * Known Brokers, Client Name, Delivery Guarantee now support expression language * Request Timeout and Message Timeout no longer claim to support expression language (as this is incompatible with TimePeriodValue validation) * deprecate Messge Key Field, which didn't work, and replace it with Kafka Key (which is what this property is called in NiFi); Kafka Key supports expression language * dynamic properties support expression language now Note: the unit test is not great, as it requires a running Kafka instance on the host, and it looks like it's included in CTest but isn't really. However, this is better than nothing, it's the same as the other two existing Kafka unit tests, and I have opened a Jira to fix these problems: https://issues.apache.org/jira/browse/MINIFICPP-1530 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
