adamdebreceni commented on a change in pull request #1037:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1037#discussion_r599563332
##########
File path: extensions/librdkafka/PublishKafka.cpp
##########
@@ -925,12 +931,10 @@ void PublishKafka::onTrigger(const
std::shared_ptr<core::ProcessContext> &contex
}
std::string kafkaKey;
- kafkaKey = "";
- if (context->getDynamicProperty(MessageKeyField, kafkaKey, flowFile) &&
!kafkaKey.empty()) {
- logger_->log_debug("PublishKafka: Message Key Field [%s]", kafkaKey);
- } else {
+ if (!context->getProperty(KafkaKey, kafkaKey, flowFile) ||
kafkaKey.empty()) {
Review comment:
if `MessageKeyField` worked before and now it no longer works we should
remove it altogether and not mark it deprecated, if we would like to enable a
"soft transition" we should mark it deprecated but further support the feature
and produce loud warnings that it will not be so for long
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
