szaszm commented on a change in pull request #1037:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1037#discussion_r600491028



##########
File path: extensions/librdkafka/PublishKafka.cpp
##########
@@ -541,6 +543,11 @@ void PublishKafka::onSchedule(const 
std::shared_ptr<core::ProcessContext> &conte
   conn_ = utils::make_unique<KafkaConnection>(key_);
   configureNewConnection(context);
 
+  std::string message_key_field;
+  if (context->getProperty(MessageKeyField.getName(), message_key_field)) {
+    logger_->log_error("The %s property is set. This property is DEPRECATED 
and has no effect; please use Kafka Key instead.", MessageKeyField.getName());

Review comment:
       Having the property set is likely a mistake, but it doesn't cause data 
loss or failures down the line. Seeing this message doesn't mean a change in 
behavior from the happy path, only that the flow is incorrect, but still 
runnable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to