adamdebreceni commented on a change in pull request #1037:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1037#discussion_r600432935
##########
File path: extensions/librdkafka/PublishKafka.cpp
##########
@@ -541,6 +543,11 @@ void PublishKafka::onSchedule(const
std::shared_ptr<core::ProcessContext> &conte
conn_ = utils::make_unique<KafkaConnection>(key_);
configureNewConnection(context);
+ std::string message_key_field;
+ if (context->getProperty(MessageKeyField.getName(), message_key_field)) {
+ logger_->log_error("The %s property is set. This property is DEPRECATED
and has no effect; please use Kafka Key instead.", MessageKeyField.getName());
Review comment:
I would go with error, as it uses a property that never worked and is
only preserved to allow the processor to operate instead of fizzling out in
onSchedule, personally I would even go for removing it, but I do not know how
prevalent its usage is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
