markap14 commented on a change in pull request #4950:
URL: https://github.com/apache/nifi/pull/4950#discussion_r604089989
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-stateless-bundle/nifi-stateless-api/src/main/java/org/apache/nifi/stateless/flow/StatelessDataflow.java
##########
@@ -24,8 +24,33 @@
import java.util.Set;
public interface StatelessDataflow {
Review comment:
I don't think we should extend `AutoCloseable` in this case. The
StatelessDataflow is not really a "resource" and is generally not used in a
such a way that you'd want to use a try-with-resources to create it for a short
period of time and then cleanup. Rather, `shutdown()` is generally used when
the application is shutdown. This involves terminating thread pools, cleaning
up potentially many resources, etc., etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
