urbandan commented on a change in pull request #4950:
URL: https://github.com/apache/nifi/pull/4950#discussion_r605415342
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-stateless-bundle/nifi-stateless-api/src/main/java/org/apache/nifi/stateless/config/PropertiesFileEngineConfigurationParser.java
##########
@@ -78,6 +79,12 @@ public StatelessEngineConfiguration
parseEngineConfiguration(final File properti
throw new StatelessConfigurationException("Working Directory " +
workingDirectory.getAbsolutePath() + " specified in properties file does not
exist and could not be created");
}
+ final String extensionsDirectoryFilename =
properties.getProperty(EXTENSIONS_DIRECTORY);
+ final File extensionsDirectory = extensionsDirectoryFilename == null ?
narDirectory : new File(extensionsDirectoryFilename);
+ if (!extensionsDirectory.exists() && !extensionsDirectory.mkdirs()) {
Review comment:
I'm not sure if the mkdirs call is ok here: the validator will fail if
the dir doesn't exist, but the actual connector/task init will pass if the dir
can be created. Seems like the validator is stricter than it should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
