fgerlits commented on a change in pull request #1040:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r605509404
##########
File path: libminifi/src/RemoteProcessorGroupPort.cpp
##########
@@ -159,9 +160,7 @@ void RemoteProcessorGroupPort::onSchedule(const
std::shared_ptr<core::ProcessCon
ssl_service =
std::static_pointer_cast<minifi::controllers::SSLContextService>(service);
} else {
std::string secureStr;
- bool is_secure = false;
- if (configure_->get(Configure::nifi_remote_input_secure, secureStr) &&
- org::apache::nifi::minifi::utils::StringUtils::StringToBool(secureStr,
is_secure)) {
+ if (configure_->get(Configure::nifi_remote_input_secure, secureStr) &&
org::apache::nifi::minifi::utils::StringUtils::toBool(secureStr).value_or(false))
{
Review comment:
minor, but `org::apache::nifi::minifi::` is not needed
in a few other places, too,
`org::apache::nifi::minifi::utils::StringUtils::toBool(...)` could be shortened
to `utils::StringUtils::toBool(...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
