szaszm commented on a change in pull request #1040:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r605576191
##########
File path: libminifi/test/unit/PropertyTests.cpp
##########
@@ -52,18 +52,6 @@ bool conversionTest(uint64_t number, core::TimeUnit unit,
uint64_t check, Conver
return returnStatus && out == check;
}
-TEST_CASE("Test Boolean Conversion", "[testboolConversion]") {
- bool b;
- REQUIRE(true ==
org::apache::nifi::minifi::utils::StringUtils::StringToBool("true", b));
- REQUIRE(true ==
org::apache::nifi::minifi::utils::StringUtils::StringToBool("True", b));
- REQUIRE(true ==
org::apache::nifi::minifi::utils::StringUtils::StringToBool("TRue", b));
- REQUIRE(true ==
org::apache::nifi::minifi::utils::StringUtils::StringToBool("tRUE", b));
- REQUIRE(false ==
org::apache::nifi::minifi::utils::StringUtils::StringToBool("FALSE", b));
- REQUIRE(false ==
org::apache::nifi::minifi::utils::StringUtils::StringToBool("FALLSEY", b));
- REQUIRE(false ==
org::apache::nifi::minifi::utils::StringUtils::StringToBool("FaLSE", b));
- REQUIRE(false ==
org::apache::nifi::minifi::utils::StringUtils::StringToBool("false", b));
-}
Review comment:
~Please convert these tests instead of removing them~
edit: nevermind, `toBool` is already tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
