szaszm commented on a change in pull request #1060:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1060#discussion_r619285211
##########
File path: extensions/sftp/tests/PutSFTPTests.cpp
##########
@@ -809,7 +809,7 @@ TEST_CASE_METHOD(PutSFTPTestsFixture, "PutSFTP batching
does not fail even if on
}
TEST_CASE_METHOD(PutSFTPTestsFixture, "PutSFTP put large file", "[PutSFTP]") {
- std::mt19937 rng(std::random_device{}());
+ std::mt19937 rng(std::random_device {}());
Review comment:
This is a false positive. We shouldn't use spaces before brace
initializers.
##########
File path: extensions/windows-event-log/wel/WindowsEventLog.h
##########
@@ -87,36 +87,36 @@ class WindowsEventLogMetadata {
static std::string getMetadataString(METADATA val) {
static std::map< METADATA, std::string> map = {
{LOG_NAME, "LOG_NAME" },
- {SOURCE,"SOURCE"},
- {TIME_CREATED,"TIME_CREATED" },
- {EVENTID,"EVENTID"},
- {OPCODE,"OPCODE"},
- {EVENT_RECORDID,"EVENT_RECORDID"},
- {EVENT_TYPE,"EVENT_TYPE"},
+ {SOURCE, "SOURCE"},
+ {TIME_CREATED, "TIME_CREATED" },
+ {EVENTID, "EVENTID"},
+ {OPCODE, "OPCODE"},
+ {EVENT_RECORDID, "EVENT_RECORDID"},
+ {EVENT_TYPE, "EVENT_TYPE"},
{TASK_CATEGORY, "TASK_CATEGORY"},
- {LEVEL,"LEVEL"},
- {KEYWORDS,"KEYWORDS"},
- {USER,"USER"},
- {COMPUTER,"COMPUTER"}
+ {LEVEL, "LEVEL"},
+ {KEYWORDS, "KEYWORDS"},
+ {USER, "USER"},
+ {COMPUTER, "COMPUTER"}
};
return map[val];
}
static METADATA getMetadataFromString(const std::string &val) {
static std::map< std::string, METADATA> map = {
- {"LOG_NAME",LOG_NAME},
- {"SOURCE",SOURCE},
- {"TIME_CREATED",TIME_CREATED },
- {"EVENTID",EVENTID},
- {"OPCODE",OPCODE},
- {"EVENT_RECORDID",EVENT_RECORDID},
+ {"LOG_NAME", LOG_NAME},
+ {"SOURCE", SOURCE},
+ {"TIME_CREATED", TIME_CREATED },
+ {"EVENTID", EVENTID},
+ {"OPCODE", OPCODE},
+ {"EVENT_RECORDID", EVENT_RECORDID},
{"TASK_CATEGORY", TASK_CATEGORY},
- {"EVENT_TYPE",EVENT_TYPE},
- {"LEVEL",LEVEL},
- {"KEYWORDS",KEYWORDS},
- {"USER",USER},
- {"COMPUTER",COMPUTER}
+ {"EVENT_TYPE", EVENT_TYPE},
+ {"LEVEL", LEVEL},
+ {"KEYWORDS", KEYWORDS},
+ {"USER", USER},
+ {"COMPUTER", COMPUTER}
Review comment:
same as above
##########
File path: extensions/windows-event-log/wel/WindowsEventLog.h
##########
@@ -87,36 +87,36 @@ class WindowsEventLogMetadata {
static std::string getMetadataString(METADATA val) {
static std::map< METADATA, std::string> map = {
{LOG_NAME, "LOG_NAME" },
- {SOURCE,"SOURCE"},
- {TIME_CREATED,"TIME_CREATED" },
- {EVENTID,"EVENTID"},
- {OPCODE,"OPCODE"},
- {EVENT_RECORDID,"EVENT_RECORDID"},
- {EVENT_TYPE,"EVENT_TYPE"},
+ {SOURCE, "SOURCE"},
+ {TIME_CREATED, "TIME_CREATED" },
+ {EVENTID, "EVENTID"},
+ {OPCODE, "OPCODE"},
+ {EVENT_RECORDID, "EVENT_RECORDID"},
+ {EVENT_TYPE, "EVENT_TYPE"},
{TASK_CATEGORY, "TASK_CATEGORY"},
- {LEVEL,"LEVEL"},
- {KEYWORDS,"KEYWORDS"},
- {USER,"USER"},
- {COMPUTER,"COMPUTER"}
+ {LEVEL, "LEVEL"},
+ {KEYWORDS, "KEYWORDS"},
+ {USER, "USER"},
+ {COMPUTER, "COMPUTER"}
Review comment:
False positives at the end of the line. Line break is a whitespace after
the commas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
