hunyadi-dev commented on a change in pull request #1060:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1060#discussion_r620056414
##########
File path: extensions/windows-event-log/wel/WindowsEventLog.h
##########
@@ -87,36 +87,36 @@ class WindowsEventLogMetadata {
static std::string getMetadataString(METADATA val) {
static std::map< METADATA, std::string> map = {
{LOG_NAME, "LOG_NAME" },
- {SOURCE,"SOURCE"},
- {TIME_CREATED,"TIME_CREATED" },
- {EVENTID,"EVENTID"},
- {OPCODE,"OPCODE"},
- {EVENT_RECORDID,"EVENT_RECORDID"},
- {EVENT_TYPE,"EVENT_TYPE"},
+ {SOURCE, "SOURCE"},
+ {TIME_CREATED, "TIME_CREATED" },
+ {EVENTID, "EVENTID"},
+ {OPCODE, "OPCODE"},
+ {EVENT_RECORDID, "EVENT_RECORDID"},
+ {EVENT_TYPE, "EVENT_TYPE"},
{TASK_CATEGORY, "TASK_CATEGORY"},
- {LEVEL,"LEVEL"},
- {KEYWORDS,"KEYWORDS"},
- {USER,"USER"},
- {COMPUTER,"COMPUTER"}
+ {LEVEL, "LEVEL"},
+ {KEYWORDS, "KEYWORDS"},
+ {USER, "USER"},
+ {COMPUTER, "COMPUTER"}
Review comment:
Good catch, It was an issue with my replacement script, I figured that
if there was no space after a comma in any reported line, there should be, but
this was a wrong assumption.
##########
File path: extensions/windows-event-log/wel/WindowsEventLog.h
##########
@@ -87,36 +87,36 @@ class WindowsEventLogMetadata {
static std::string getMetadataString(METADATA val) {
static std::map< METADATA, std::string> map = {
{LOG_NAME, "LOG_NAME" },
- {SOURCE,"SOURCE"},
- {TIME_CREATED,"TIME_CREATED" },
- {EVENTID,"EVENTID"},
- {OPCODE,"OPCODE"},
- {EVENT_RECORDID,"EVENT_RECORDID"},
- {EVENT_TYPE,"EVENT_TYPE"},
+ {SOURCE, "SOURCE"},
+ {TIME_CREATED, "TIME_CREATED" },
+ {EVENTID, "EVENTID"},
+ {OPCODE, "OPCODE"},
+ {EVENT_RECORDID, "EVENT_RECORDID"},
+ {EVENT_TYPE, "EVENT_TYPE"},
{TASK_CATEGORY, "TASK_CATEGORY"},
- {LEVEL,"LEVEL"},
- {KEYWORDS,"KEYWORDS"},
- {USER,"USER"},
- {COMPUTER,"COMPUTER"}
+ {LEVEL, "LEVEL"},
+ {KEYWORDS, "KEYWORDS"},
+ {USER, "USER"},
+ {COMPUTER, "COMPUTER"}
};
return map[val];
}
static METADATA getMetadataFromString(const std::string &val) {
static std::map< std::string, METADATA> map = {
- {"LOG_NAME",LOG_NAME},
- {"SOURCE",SOURCE},
- {"TIME_CREATED",TIME_CREATED },
- {"EVENTID",EVENTID},
- {"OPCODE",OPCODE},
- {"EVENT_RECORDID",EVENT_RECORDID},
+ {"LOG_NAME", LOG_NAME},
+ {"SOURCE", SOURCE},
+ {"TIME_CREATED", TIME_CREATED },
+ {"EVENTID", EVENTID},
+ {"OPCODE", OPCODE},
+ {"EVENT_RECORDID", EVENT_RECORDID},
{"TASK_CATEGORY", TASK_CATEGORY},
- {"EVENT_TYPE",EVENT_TYPE},
- {"LEVEL",LEVEL},
- {"KEYWORDS",KEYWORDS},
- {"USER",USER},
- {"COMPUTER",COMPUTER}
+ {"EVENT_TYPE", EVENT_TYPE},
+ {"LEVEL", LEVEL},
+ {"KEYWORDS", KEYWORDS},
+ {"USER", USER},
+ {"COMPUTER", COMPUTER}
Review comment:
same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
