szaszm commented on a change in pull request #1065:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1065#discussion_r622081212
##########
File path: libminifi/src/utils/OsUtils.cpp
##########
@@ -168,6 +168,11 @@ std::string OsUtils::userIdToUsername(const std::string
&uid) {
return name;
}
+[[deprecated("Unsupported platform")]]
Review comment:
This is still compiled as c++11. This attribute was introduced in c++14.
Also, I wouldn't consider this deprecated, but more like a fallback.
https://en.cppreference.com/w/cpp/language/attributes/deprecated
edit: I don't know why, but it compiles on gcc 4.8 in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
