szaszm commented on a change in pull request #1065:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1065#discussion_r622147996
##########
File path: libminifi/src/utils/OsUtils.cpp
##########
@@ -168,6 +168,11 @@ std::string OsUtils::userIdToUsername(const std::string
&uid) {
return name;
}
+[[deprecated("Unsupported platform")]]
Review comment:
I would go for `#warning`. Non-MSVC compilers tend to support this GCC
extension, and MSVC is handled anyway.
https://gcc.gnu.org/onlinedocs/cpp/Diagnostics.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
