szaszm commented on a change in pull request #1044:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1044#discussion_r622390469
##########
File path: CMakeLists.txt
##########
@@ -564,6 +560,14 @@ if (ENABLE_ALL OR ENABLE_AZURE)
createExtension(AZURE-EXTENSIONS "AZURE EXTENSIONS" "This enables Azure
support" "extensions/azure" "${TEST_DIR}/azure-tests")
endif()
+## Add the systemd extension
+if(CMAKE_SYSTEM_NAME STREQUAL "Linux")
+ option(DISABLE_SYSTEMD "Disables the systemd extension." OFF)
Review comment:
The reason it's `DISABLE_SYSTEMD` is that it's enabled by default on
supported platforms and I think the pattern is that the option is the opposite
of the default. There's already an exception to this, but it might be an
accident or just that it doesn't correspont to an extension (AFAIK):
`ENABLE_OPS`.
Given this, do you still want to change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
