adamdebreceni commented on a change in pull request #1044:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1044#discussion_r629989355
##########
File path: CMakeLists.txt
##########
@@ -564,6 +560,14 @@ if (ENABLE_ALL OR ENABLE_AZURE)
createExtension(AZURE-EXTENSIONS "AZURE EXTENSIONS" "This enables Azure
support" "extensions/azure" "${TEST_DIR}/azure-tests")
endif()
+## Add the systemd extension
+if(CMAKE_SYSTEM_NAME STREQUAL "Linux")
+ option(DISABLE_SYSTEMD "Disables the systemd extension." OFF)
Review comment:
I feel strongly against double negatives, I think we should avoid it
like plague, I already got confused by what you wrote, what is even more
magical is the following:
```
add_enabled_option(){
eval "$1=$2"
OPTIONS+=("$1")
CMAKE_OPTIONS_DISABLED+=("$1:$3")
}
```
the `add_enabled_option` appends to the `CMAKE_OPTIONS_DISABLED` variable 🤯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
