markap14 commented on a change in pull request #5042:
URL: https://github.com/apache/nifi/pull/5042#discussion_r625951543



##########
File path: nifi-api/src/main/java/org/apache/nifi/processor/ProcessSession.java
##########
@@ -101,6 +102,105 @@
      */
     void commit();
 
+    /**
+     * <p>

Review comment:
       Yeah I would like a better name than `commitAsync()` but it's the best I 
could come up with. We cannot change `commit()` to `commitSynchronous()` 
though. That would not be a backward compatible change. Effectively, we would 
be completely changing the semantics of the `commit()` call.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to