markap14 commented on a change in pull request #5042:
URL: https://github.com/apache/nifi/pull/5042#discussion_r625969914
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/protocol/AbstractFlowFileServerProtocol.java
##########
@@ -375,7 +375,7 @@ protected int commitTransferTransaction(Peer peer,
FlowFileTransaction transacti
throw new ProtocolException("After sending data, expected
TRANSACTION_FINISHED response but got " + transactionResponse);
}
- session.commit();
+ session.commitAsync();
Review comment:
Yeah that was intentionally left as `session.commit()`. After committing
the session, it responds with a 'success' indicator, acknowledging receipt.
However, after doing so, it also returns a value. So it wasn't as trivial as
just wrapping a few lines into a callback. So i opted to leave it untouched for
this PR and it can be addressed in a follow-on Jira
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
