ChrisSamo632 commented on a change in pull request #4822:
URL: https://github.com/apache/nifi/pull/4822#discussion_r626770932
##########
File path:
nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java
##########
@@ -21,7 +21,7 @@
public abstract class AbstractProcessor extends
AbstractSessionFactoryProcessor {
@Override
- public final void onTrigger(final ProcessContext context, final
ProcessSessionFactory sessionFactory) throws ProcessException {
+ public void onTrigger(final ProcessContext context, final
ProcessSessionFactory sessionFactory) throws ProcessException {
Review comment:
RE option 1 - I considered this but decided against it because the new
processor does use *some* of the existing abstract AWS processor logic (e.g.
Proxy config & Auth). I didn't much fancy re-implementing that separately and
also it could be difficult to keep the refactored processor closely aligned
enough to future AWS Processor bundle updates in future (people easily not
realising that they needed to make the same changes more than once within the
bundle).
I think there should be a separate Jira ticket to refactor the processors
(or this could be considered as part of the migration to AWS SDK 2.x, a ticket
for which I've previously raised) - the AWS bundle could certainly stand some
rework/simplkfication, but this PR is already big enough IMO
I've implemented option 3 currently in this PR, reworking to option 2
shouldn't be a big change if decided that's to preferred way forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
