ChrisSamo632 commented on a change in pull request #4822: URL: https://github.com/apache/nifi/pull/4822#discussion_r627181783
########## File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/record/AbstractKinesisRecordProcessor.java ########## @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.aws.kinesis.stream.record; + +import com.amazonaws.services.kinesis.clientlibrary.exceptions.InvalidStateException; +import com.amazonaws.services.kinesis.clientlibrary.exceptions.ShutdownException; +import com.amazonaws.services.kinesis.clientlibrary.exceptions.ThrottlingException; +import com.amazonaws.services.kinesis.clientlibrary.interfaces.IRecordProcessorCheckpointer; +import com.amazonaws.services.kinesis.clientlibrary.interfaces.v2.IRecordProcessor; +import com.amazonaws.services.kinesis.clientlibrary.lib.worker.ShutdownReason; +import com.amazonaws.services.kinesis.clientlibrary.types.InitializationInput; +import com.amazonaws.services.kinesis.clientlibrary.types.ProcessRecordsInput; +import com.amazonaws.services.kinesis.clientlibrary.types.ShutdownInput; +import com.amazonaws.services.kinesis.model.Record; +import org.apache.nifi.flowfile.FlowFile; +import org.apache.nifi.logging.ComponentLog; +import org.apache.nifi.processor.ProcessSession; +import org.apache.nifi.processor.ProcessSessionFactory; +import org.apache.nifi.processor.Relationship; +import org.apache.nifi.processors.aws.kinesis.stream.ConsumeKinesisStream; +import org.apache.nifi.util.StopWatch; + +import java.time.ZoneId; +import java.time.format.DateTimeFormatter; +import java.util.ArrayList; +import java.util.Base64; +import java.util.Date; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +public abstract class AbstractKinesisRecordProcessor implements IRecordProcessor { + public static final String AWS_KINESIS_SHARD_ID = "aws.kinesis.shard.id"; + + public static final String AWS_KINESIS_SEQUENCE_NUMBER = "aws.kinesis.sequence.number"; + + public static final String AWS_KINESIS_PARTITION_KEY = "aws.kinesis.partition.key"; + + public static final String AWS_KINESIS_APPROXIMATE_ARRIVAL_TIMESTAMP = "aws.kinesis.approximate.arrival.timestamp"; + + public static final String KINESIS_RECORD_SCHEMA_KEY = "kinesis.name"; + + static final Base64.Encoder BASE_64_ENCODER = Base64.getEncoder(); + + final ProcessSessionFactory sessionFactory; + final ComponentLog log; + final String streamName; + final String endpointPrefix; + + final long checkpointIntervalMillis; + final long retryWaitMillis; + final int numRetries; + final DateTimeFormatter dateTimeFormatter; + + String kinesisShardId; + long nextCheckpointTimeInMillis; + + boolean processingRecords = false; + + @SuppressWarnings("java:S107") + AbstractKinesisRecordProcessor(final ProcessSessionFactory sessionFactory, final ComponentLog log, final String streamName, + final String endpointPrefix, final long checkpointIntervalMillis, final long retryWaitMillis, + final int numRetries, final DateTimeFormatter dateTimeFormatter) { + this.sessionFactory = sessionFactory; + this.log = log; + this.streamName = streamName; + this.endpointPrefix = endpointPrefix; + this.checkpointIntervalMillis = checkpointIntervalMillis; + this.retryWaitMillis = retryWaitMillis; + this.numRetries = numRetries; + this.dateTimeFormatter = dateTimeFormatter; + } + + @Override + public void initialize(final InitializationInput initializationInput) { + if (initializationInput.getPendingCheckpointSequenceNumber() != null) { + log.warn("Initializing record processor for stream: {} / shard {}; from sequence number: {}; indicates previously uncheckpointed sequence number: {}", + streamName, initializationInput.getShardId(), initializationInput.getExtendedSequenceNumber(), initializationInput.getPendingCheckpointSequenceNumber()); + } else { + log.debug("Initializing record processor for stream: {} / shard: {}; from sequence number: {}", + streamName, initializationInput.getShardId(), initializationInput.getExtendedSequenceNumber()); + } + + this.kinesisShardId = initializationInput.getShardId(); + + // ensure we don't immediately checkpoint + this.nextCheckpointTimeInMillis = System.currentTimeMillis() + checkpointIntervalMillis; + } + + @SuppressWarnings({"java:S3252"}) // ConsumeKinesisStream reference to REL_SUCCESS instead of deprecated AbstractAWSProcessor + @Override + public void processRecords(final ProcessRecordsInput processRecordsInput) { + log.debug("Processing {} records from {}; cache entry: {}; cache exit: {}; millis behind latest: {}", + processRecordsInput.getRecords().size(), kinesisShardId, + processRecordsInput.getCacheEntryTime() != null ? dateTimeFormatter.format(processRecordsInput.getCacheEntryTime().atZone(ZoneId.systemDefault())) : null, + processRecordsInput.getCacheExitTime() != null ? dateTimeFormatter.format(processRecordsInput.getCacheExitTime().atZone(ZoneId.systemDefault())) : null, + processRecordsInput.getMillisBehindLatest()); Review comment: Tried to catch these, but evidently missed one... good spot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
