joewitt commented on a change in pull request #5057:
URL: https://github.com/apache/nifi/pull/5057#discussion_r626776570
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/FTPTransfer.java
##########
@@ -606,7 +606,7 @@ private FTPClient getClient(final FlowFile flowFile) throws
IOException {
client.setAutodetectUTF8(useUtf8Encoding);
}
- client.connect(inetAddress,
ctx.getProperty(PORT).evaluateAttributeExpressions(flowFile).asInteger());
+ client.connect(remoteHostName,
ctx.getProperty(PORT).evaluateAttributeExpressions(flowFile).asInteger());
Review comment:
This change as-is needs more work. We create the inetAddress in
previous lines using this remoteHostName value. This change just ignores all
those lines. So we need to understand why those other lines aren't needed
anymore and remove them. There is a proxyHostname property available too.
Makes me wonder if we're using the wrong value here. Genearlly we need to
tighten this up.
In any event it appears this is your first time attempting to contribute
code. Much appreciated either way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
