markobean commented on pull request #5064:
URL: https://github.com/apache/nifi/pull/5064#issuecomment-839980571
Looks great. Thanks for adding the major/minor option.
Here's some testing I did:
From context menu, selected each of the Background grid options:
Show only major ticks
Hide grid
Show full grid
Verified each display option was accurate
Verified only the two options not the current mode displayed, e.g. when Hide
grid is selected, only Show full grid and Show only major ticks are available
menu options
Refreshed display in each mode ensuring grid settings remained the same
(context menu refresh and browser refresh)
Tested in Chrome (88.0) and Firefox (60.0) - I know, pretty old, but I can
retest on a different platform if desired
Verified settings on one browser did not affect view in another browser.
(Different tabs of the same browser would update settings when using the
browser refresh button.)
Grid scales along with other components on the graph when zooming in and
out. (This is new behavior, and more natural IMO.)
Overall, LGTM, +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
