markap14 commented on pull request #5064: URL: https://github.com/apache/nifi/pull/5064#issuecomment-860792823
Thanks @gschaer. I think took a look at the UI and played with it some. I can see some benefit in the ability to show/hide the grid. And I do like that the grid changes size as the user zooms in and out. However, I find it a bit disorienting with the current sizes of the gridlines. They are quite a lot smaller than the old gridlines. It also means that with this update, all of the images in the User Guide, etc. all of our documentation are now out of date. I think it makes more sense to keep the size of the grid so that the gridlines are the same as they were before when zoomed into a 1:1 ratio (i.e., when you click the "Actual" button on the Navigate panel). I'm also not really qualified to review the UI portion, as I have little experience with JavaScript / CSS so I'd like to see a committer who's done a lot of UI work review the UI code as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
