szaszm commented on a change in pull request #1083:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1083#discussion_r643809282
##########
File path: controller/Controller.h
##########
@@ -36,7 +36,7 @@ bool sendSingleCommand(std::unique_ptr<minifi::io::Socket>
socket, uint8_t op, c
minifi::io::BufferStream stream;
stream.write(&op, 1);
stream.write(value);
- return
static_cast<size_t>(socket->write(const_cast<uint8_t*>(stream.getBuffer()),
gsl::narrow<int>(stream.size()))) == stream.size();
+ return socket->write(const_cast<uint8_t*>(stream.getBuffer()),
stream.size()) == stream.size();
Review comment:
No, it's not. Will remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
