martinzink commented on a change in pull request #1083:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1083#discussion_r647170320
##########
File path: extensions/http-curl/client/HTTPStream.cpp
##########
@@ -36,7 +37,7 @@ namespace minifi {
namespace io {
HttpStream::HttpStream(std::shared_ptr<utils::HTTPClient> client)
- : http_client_(client),
+ : http_client_(std::move(client)),
Review comment:
now we are copying the client shared_ptr when this ctor is called and
then move the copy into the client_ member
wouldnt it be more readable to just use const & and then copy that into the
client_ member?
same with SensorBase::WriteCallback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
