markobean opened a new pull request #5192:
URL: https://github.com/apache/nifi/pull/5192
…tion
- include new process group property support in NiFi Registry
- updated documentation to describe and show new feature
- added elements to XSD schema definition
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Adds properties to the Process Group configuration setting the default
values for all newly created connections. This facilitates easier configuration
during flow creation especially with multi-tenancy in mind. There are 3
properties added: default flowfile expiration, default back pressure object
threshold, default back pressure data size threshold.
See updated User Guide for additional information.
The new behavior includes a basic unit test. It was also tested extensively
in a running NiFi as some features are heavily UI-dependent.
Verified the new elements of the Process Group (PG) DTO are populated into
flow.xml.gz when NiFi is started using an older format, i.e. without the new
elements included; no warnings are issued to nifi-app.log
Verified export/import of process groups maintains property settings when
using templates, NiFi Registry and JSON flow definition
Verified the default values of the added elements are “0 sec” for FlowFile
Expiration, and obtained from nifi.properties for back pressure settings
Verified PG settings are displayed as non-editable when user is not in the
‘modify the component’ policy.
Verified PG settings are displayed as “Unauthorized” when user is not in the
‘view the component’ policy.
Verified new connection defaults change as the PG settings change
Verified the settings of existing connections do not change as the PG
settings change
Verified newly created PG inherits strings from parent
Verified settings of existing child PG do not change as parent PG settings
change
Verified User Guide documentation updated and displays correctly
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
