mattyb149 commented on a change in pull request #5192:
URL: https://github.com/apache/nifi/pull/5192#discussion_r664895968
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/dao/impl/StandardProcessGroupDAO.java
##########
@@ -373,6 +373,11 @@ public ProcessGroup updateProcessGroup(ProcessGroupDTO
processGroupDTO) {
if (flowFileOutboundPolicy != null) {
group.setFlowFileOutboundPolicy(flowFileOutboundPolicy);
}
+
+
group.setDefaultFlowFileExpiration(processGroupDTO.getDefaultFlowFileExpiration());
Review comment:
When the position is changed, all other fields in the DTO are null. When
`getDefaultFlowFileExpiration()` is null, `setDefaultFlowFileExpiration()` sets
the system default. These method calls should check for null like the code
right above it, and not call `set` if the value is null (but leave the
defensive code in StandardProcessGroup)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
