adamdebreceni commented on a change in pull request #1090:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1090#discussion_r664378255
##########
File path: extensions/rocksdb-repos/database/RocksDbUtils.h
##########
@@ -38,19 +38,14 @@ class Writable {
public:
explicit Writable(T& target) : target_(target) {}
- template<typename F>
- void set(F T::* member, typename utils::type_identity<F>::type value) {
- if (!(target_.*member == value)) {
+ template<typename F, typename Comparator = std::equal_to<F>>
+ void set(F T::* member, typename utils::type_identity<F>::type value, const
Comparator& comparator = Comparator{}) {
+ if (!comparator(target_.*member, value)) {
target_.*member = value;
is_modified_ = true;
}
}
- template<typename Transformer, typename F>
- void transform(F T::* member) {
- set(member, Transformer::transform(target_.*member));
- }
Review comment:
yes, removed in
[b13b5b7](https://github.com/apache/nifi-minifi-cpp/pull/1090/commits/b13b5b7d24b681c15e15850d36ce2922b5f2b9e9)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
