adamdebreceni commented on a change in pull request #1090: URL: https://github.com/apache/nifi-minifi-cpp/pull/1090#discussion_r664399347
########## File path: libminifi/test/rocksdb-tests/EncryptionTests.cpp ########## @@ -0,0 +1,108 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "../TestBase.h" +#include "utils/TestUtils.h" +#include "FlowFileRepository.h" +#include "utils/IntegrationTestUtils.h" + +using utils::Path; +using core::repository::FlowFileRepository; + +class FFRepoFixture : public TestController { + public: + FFRepoFixture() { + LogTestController::getInstance().setDebug<minifi::FlowFileRecord>(); + LogTestController::getInstance().setDebug<minifi::Connection>(); + LogTestController::getInstance().setTrace<FlowFileRepository>(); + home_ = createTempDirectory("/var/tmp/testRepo.XXXXXX"); + repo_dir_ = home_ / "flowfile_repo"; + checkpoint_dir_ = home_ / "checkpoint_dir"; + config_ = std::make_shared<minifi::Configure>(); + config_->setHome(home_.str()); + container_ = std::make_shared<minifi::Connection>(nullptr, nullptr, "container"); + content_repo_ = std::make_shared<core::repository::VolatileContentRepository>(); + content_repo_->initialize(config_); + } + + static void putFlowFile(const std::shared_ptr<minifi::FlowFileRecord>& flowfile, const std::shared_ptr<core::repository::FlowFileRepository>& repo) { + minifi::io::BufferStream buffer; + flowfile->Serialize(buffer); + REQUIRE(repo->Put(flowfile->getUUIDStr(), buffer.getBuffer(), buffer.size())); + } + + template<typename Fn> + void runWithNewRepository(Fn&& fn) { + auto repository = std::make_shared<FlowFileRepository>("ff", checkpoint_dir_.str(), repo_dir_.str()); + repository->initialize(config_); + std::map<std::string, std::shared_ptr<core::Connectable>> container_map; + container_map[container_->getUUIDStr()] = container_; + repository->setContainers(container_map); + repository->loadComponent(content_repo_); + repository->start(); + std::forward<Fn>(fn)(repository); + repository->stop(); + } + + protected: + std::shared_ptr<minifi::Connection> container_; + Path home_; + Path repo_dir_; + Path checkpoint_dir_; + std::shared_ptr<minifi::Configure> config_; + std::shared_ptr<core::repository::VolatileContentRepository> content_repo_; +}; + +TEST_CASE_METHOD(FFRepoFixture, "FlowFileRepository creates checkpoint and loads flowfiles") { + SECTION("Without encryption") { + // pass + } + SECTION("With encryption") { + utils::file::FileUtils::create_dir((home_ / "conf").str()); + std::ofstream{(home_ / "conf" / "bootstrap.conf").str()} + << static_cast<const char*>(FlowFileRepository::ENCRYPTION_KEY_NAME) << "=" Review comment: since we have an rvalue ref stream `operator<<` will resolve to a forwarding template function ``` template <class _Stream, class _Tp> inline _LIBCPP_INLINE_VISIBILITY typename enable_if < !is_lvalue_reference<_Stream>::value && is_base_of<ios_base, _Stream>::value, _Stream&& >::type operator<<(_Stream&& __os, const _Tp& __x) { __os << __x; return _VSTD::move(__os); } ``` which takes the argument by reference, which makes the static member [odr-used](https://en.cppreference.com/w/cpp/language/definition#ODR-use), adding a `static_cast` makes an lvalue-to-rvalue conversion which evaluates to a constant expression, and no longer odr-used, from `c++17` we won't need this cast -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
