ChrisSamo632 commented on a change in pull request #5195:
URL: https://github.com/apache/nifi/pull/5195#discussion_r663966104
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/bootstrap.conf
##########
@@ -105,3 +105,10 @@ notification.max.attempts=5
# The first curator connection issue is logged as ERROR, for example when NiFi
cannot connect to one of the Zookeeper nodes.
# Additional connection issues are logged as DEBUG until the connection is
restored.
java.arg.curator.supress.excessive.logs=-Dcurator-log-only-first-connection-issue-as-error-level=true
+
+# Diagnostics
+nifi.diag.allowed=true
Review comment:
Creating diagnostics for everyone by default seems the wrong change to
make - I'd default this to `false` otherwise existing installations will
suddenly find their filesystems filling up with unexpected files whenever their
NiFi instance restarts (the default settings also allow *many* files to be
retained, so I could easily see people getting a bit confused/frustrated with
the fact that diagnostics files are filling up their filesystems)
If this is left as `true` I'd greatly reduce the default `max` retention
settings (e.g. keep up to the last 2 or 10 files)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
