ChrisSamo632 commented on a change in pull request #5195:
URL: https://github.com/apache/nifi/pull/5195#discussion_r674933497
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/bootstrap.conf
##########
@@ -105,3 +105,10 @@ notification.max.attempts=5
# The first curator connection issue is logged as ERROR, for example when NiFi
cannot connect to one of the Zookeeper nodes.
# Additional connection issues are logged as DEBUG until the connection is
restored.
java.arg.curator.supress.excessive.logs=-Dcurator-log-only-first-connection-issue-as-error-level=true
+
+# Diagnostics
+nifi.diag.allowed=true
Review comment:
(As a general note, I'd prefer comments to be left for the original
author to Resolve, otherwise I've got to work back through all comments to see
what it was I previously identified as needing work)
However, happy with the change to `false` by default, but this feature seems
like something that should be included in the Admin Guide, particularly if
simply setting `nifi.diag.allowed` to `true` without changing anything else
would effectively allow the system to keep generating diganostic files until
the disk filled up - that's something administrators should probably think
about changing when enabling this functionality
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
