markobean commented on a change in pull request #5192:
URL: https://github.com/apache/nifi/pull/5192#discussion_r665553747



##########
File path: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowSynchronizer.java
##########
@@ -1197,9 +1197,15 @@ private void updateProcessGroup(final ProcessGroup 
group, final ProcessGroupDTO
             }
         }
 
-        group.setDefaultFlowFileExpiration(defaultFlowFileExpiration);
-        
group.setDefaultBackPressureObjectThreshold(defaultBackPressureObjectThreshold);
-        
group.setDefaultBackPressureDataSizeThreshold(defaultBackPressureDataSizeThreshold);
+        if (defaultFlowFileExpiration == null) {

Review comment:
       Yes, they should. I was moving too quickly and using the above 
flowFileOutboundPolicyName as an example.. but that is just setting defaults in 
case of null. 
   Fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to