szaszm commented on a change in pull request #1130:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1130#discussion_r668061401
##########
File path: libminifi/test/aws-tests/AWSCredentialsServiceTest.cpp
##########
@@ -65,3 +77,28 @@ TEST_CASE_METHOD(AWSCredentialsServiceTestAccessor, "Test
expired credentials ar
// Check for credential refresh
REQUIRE_FALSE(aws_credentials_impl->getAWSCredentials()->IsExpired());
}
+
+TEST_CASE_METHOD(AWSCredentialsServiceTestAccessor, "Test credentials from
default credential chain are always refreshed", "[credentialRefresh]") {
+ setEnvironmentCredentials("key", "secret");
+ plan->setProperty(aws_credentials_service, "Use Default Credentials",
"true");
+ aws_credentials_service->enable();
+ assert(aws_credentials_service->getControllerServiceImplementation() !=
nullptr);
+ auto aws_credentials_impl =
std::static_pointer_cast<minifi::aws::controllers::AWSCredentialsService>(aws_credentials_service->getControllerServiceImplementation());
+
+ // Check intial credentials
+ REQUIRE(aws_credentials_impl->getAWSCredentials());
+ REQUIRE(aws_credentials_impl->getAWSCredentials()->GetAWSAccessKeyId() ==
"key");
+ REQUIRE(aws_credentials_impl->getAWSCredentials()->GetAWSSecretKey() ==
"secret");
+ REQUIRE_FALSE(aws_credentials_impl->getAWSCredentials()->IsExpired());
+
+ // Set new credentials
+ setEnvironmentCredentials("key2", "secret2");
+
+ // Check for credential refresh
+ REQUIRE(aws_credentials_impl->getAWSCredentials());
+ REQUIRE(aws_credentials_impl->getAWSCredentials()->GetAWSAccessKeyId() ==
"key2");
+ REQUIRE(aws_credentials_impl->getAWSCredentials()->GetAWSSecretKey() ==
"secret2");
+ REQUIRE_FALSE(aws_credentials_impl->getAWSCredentials()->IsExpired());
+}
+
+}
Review comment:
```suggestion
} // namespace
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
