lordgamez commented on pull request #1130: URL: https://github.com/apache/nifi-minifi-cpp/pull/1130#issuecomment-878925713
> > > as I see in `AWSCredentialsProvider::getAWSCredentials()` the `use_default_credentials_` branch falls through if we cannot acquire credentials from the default provider chain, is that intentional? > > > > > > Yes, in that case we still try to check if we can find any other set credentials like the access key and secret key from properties or the credentials file as a backup. > > and should we? I mean if I explicitly request the usage of default credentials shouldn't other user provided options be ignored? I see your point, but if the user explicitly sets the `Access Key` and the default credentials chain does not have any credentials to provide, should that be ignored as well? I think it could be a bigger problem for the user if they forget to turn off the default credential chain option and then after setting the credentials manually, they get an error that no credentials are available. It could take a long time to debug why those credentials were ignored. I look at the `AWSCredentialsProvider` as more of a priority list, where if the default credential chain is set that should be the priority, but if that is not available then the other options should be checked as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
