[ 
https://issues.apache.org/jira/browse/NIFI-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586035#comment-15586035
 ] 

ASF GitHub Bot commented on NIFI-1769:
--------------------------------------

Github user jvwing commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1126#discussion_r83901899
  
    --- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
 ---
    @@ -200,15 +201,24 @@
                 .displayName("Server Side Encryption")
                 .description("Specifies the algorithm used for server side 
encryption.")
                 .required(true)
    -            .allowableValues(NO_SERVER_SIDE_ENCRYPTION, 
ObjectMetadata.AES_256_SERVER_SIDE_ENCRYPTION)
    +            .allowableValues(NO_SERVER_SIDE_ENCRYPTION, 
ObjectMetadata.AES_256_SERVER_SIDE_ENCRYPTION, KMS_MANAGED)
                 .defaultValue(NO_SERVER_SIDE_ENCRYPTION)
                 .build();
     
    +    public static final PropertyDescriptor AWS_KMS_KEY = new 
PropertyDescriptor.Builder()
    +            .name("aws-kms-key")
    +            .displayName("Server Side Encryption using KMS")
    --- End diff --
    
    I recommend the displayName be a bit more direct, this field is the alias 
of a KMS key, and it's going to be used for SSE.


> Add support for SSE-KMS and S3 Signature Version 4 Authentication AWS
> ---------------------------------------------------------------------
>
>                 Key: NIFI-1769
>                 URL: https://issues.apache.org/jira/browse/NIFI-1769
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 0.5.1
>            Reporter: Michiel Moonen
>            Priority: Minor
>              Labels: newbie, patch, security
>
> Currently there is no support for SSE-KMS S3 Signature Version 4 
> Authentication. This is necessary for enhanced security features



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to