[ 
https://issues.apache.org/jira/browse/NIFI-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586036#comment-15586036
 ] 

ASF GitHub Bot commented on NIFI-1769:
--------------------------------------

Github user jvwing commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1126#discussion_r83904222
  
    --- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
 ---
    @@ -458,6 +471,13 @@ public void process(final InputStream rawIn) throws 
IOException {
                                 // single part upload
                                 //----------------------------------------
                                 final PutObjectRequest request = new 
PutObjectRequest(bucket, key, in, objectMetadata);
    +                            if (keyId != null) {
    +                                    if 
(!context.getProperty(SIGNER_OVERRIDE).getValue().equals("AWSS3V4Signer")) {
    +                                            getLogger().error("Uploading 
with AWS:KMS requires S3V4 signature, please enable it");
    +                                            return;
    --- End diff --
    
    The `return` here routes the flowfile to success without going to S3.  Is 
that intended?


> Add support for SSE-KMS and S3 Signature Version 4 Authentication AWS
> ---------------------------------------------------------------------
>
>                 Key: NIFI-1769
>                 URL: https://issues.apache.org/jira/browse/NIFI-1769
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 0.5.1
>            Reporter: Michiel Moonen
>            Priority: Minor
>              Labels: newbie, patch, security
>
> Currently there is no support for SSE-KMS S3 Signature Version 4 
> Authentication. This is necessary for enhanced security features



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to