szaszm commented on a change in pull request #1132:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1132#discussion_r675550590
##########
File path: libminifi/src/core/yaml/YamlConfiguration.cpp
##########
@@ -805,6 +807,38 @@ void YamlConfiguration::parsePropertiesNodeYaml(const
YAML::Node& propertiesNode
validateComponentProperties(processor, component_name, yaml_section);
}
+void YamlConfiguration::parseFunnelsYaml(const YAML::Node& node,
core::ProcessGroup* parent) {
+ if (!parent) {
+ logger_->log_error("parseFunnelsYaml: no parent group was provided");
+ return;
+ }
+ if (!node || !node.IsSequence()) {
+ return;
+ }
+
+ for (const auto& element : node) {
+ // for (YAML::const_iterator iter = node.begin(); iter != node.end();
++iter) {
+ YAML::Node funnel_node = element.as<YAML::Node>();
+
+ std::string id = getOrGenerateId(funnel_node);
+
+ // Default name to be same as ID
+ std::string name = funnel_node["name"].as<std::string>(id);
+
+ const utils::optional<utils::Identifier> uuid =
utils::Identifier::parse(id);
+ if (!uuid) {
+ logger_->log_debug("Incorrect connection UUID format.");
+ throw Exception(ExceptionType::GENERAL_EXCEPTION, "Incorrect connection
UUID format.");
+ }
Review comment:
You changed a different occurrence of the same pattern. Line 610 vs 826.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
