szaszm commented on a change in pull request #1107:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1107#discussion_r672437833
##########
File path: extensions/sql/processors/QueryDatabaseTable.cpp
##########
@@ -220,7 +219,9 @@ void
QueryDatabaseTable::initializeMaxValues(core::ProcessContext &context) {
logger_->log_info("Found no stored state");
} else {
if (!loadMaxValuesFromStoredState(stored_state)) {
+ state_manager_->beginTransaction();
state_manager_->clear();
+ state_manager_->commit();
Review comment:
What are the new semantics that make these extra calls necessary?
##########
File path: cmake/BuildTests.cmake
##########
@@ -151,11 +151,13 @@ SET(INT_TEST_COUNT 0)
FOREACH(testfile ${INTEGRATION_TESTS})
get_filename_component(testfilename "${testfile}" NAME_WE)
add_executable("${testfilename}" "${TEST_DIR}/integration/${testfile}")
+ target_wholearchive_library("${testfilename}" minifi-standard-processors)
Review comment:
What changed that makes this link necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
