szaszm commented on a change in pull request #1107:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1107#discussion_r677307361
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -332,7 +334,6 @@ void ConsumeWindowsEventLog::onSchedule(const
std::shared_ptr<core::ProcessConte
bool ConsumeWindowsEventLog::commitAndSaveBookmark(const std::wstring
&bookmark_xml, const std::shared_ptr<core::ProcessSession> &session) {
{
const TimeDiff time_diff;
- session->commit();
Review comment:
For the record: This was a bad idea, I mistakenly identified the first
block as the function body. We discussed the solution in private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
