lordgamez commented on a change in pull request #1120:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1120#discussion_r681066965
##########
File path: extensions/librdkafka/ConsumeKafka.cpp
##########
@@ -185,7 +205,11 @@ void ConsumeKafka::initialize() {
DuplicateHeaderHandling,
MaxPollRecords,
MaxPollTime,
- SessionTimeout
+ SessionTimeout,
+ SecurityCA,
+ SecurityCert,
+ SecurityPrivateKey,
+ SecurityPrivateKeyPassword
Review comment:
I'm on the edge about this. It's true that NiFi uses SSLContextService
and that would make sense that we would use it as well as it is already
implemented. But in the kafka extension we currently have the `PublishKafka`
and the `ConsumeKafka` processors and as `PublishKafka` uses these attributes
for SSL configuration instead of the SSLContextService it would also make sense
to have the same properties in `ConsumeKafka` to be consistent within the
extension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
