lordgamez commented on a change in pull request #1120:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1120#discussion_r681072581
##########
File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp
##########
@@ -586,4 +598,19 @@ TEST_CASE_METHOD(ConsumeKafkaContinuousPublishingTest,
"ConsumeKafka can spend n
// I tried adding a wait time for more than "session.timeout.ms" inbetween
tests, but it was not sufficient
}
+TEST_CASE_METHOD(ConsumeKafkaPropertiesTest, "ConsumeKafka can communicate
with the broker via SSL.", "[ConsumeKafka][Kafka][SSL]") {
+ auto run_tests = [&] (const std::vector<std::string>& messages_on_topic) {
+ single_consumer_with_plain_text_test(true, {}, messages_on_topic,
NON_TRANSACTIONAL_MESSAGES, {}, "localhost:9093",
ConsumeKafka::SECURITY_PROTOCOL_SSL, "ConsumeKafkaTest", {}, {},
"test_group_id", {}, {}, {}, {}, {}, {}, "1", "2 sec", "60 sec"); // NOLINT
+ };
+ const auto get_current_timestamp = [] {
+ const std::time_t result = std::time(nullptr);
+ std::stringstream time_stream;
+ time_stream << std::asctime(std::localtime(&result));
+ return time_stream.str();
+ };
Review comment:
I would prefer not to put too much additional effort into these tests,
as there is already a [Jira
ticket](https://issues.apache.org/jira/browse/MINIFICPP-1518) for removing them
in the future, as it is only a manual test suite and the test cases are already
implemented (or mostly implemented) in the integration test suite. After this
PR is merged the parity between the manual and the automated test suites of the
kafka extension should be evaluated and after the gaps are fixed, the manual
suites can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
