lordgamez commented on a change in pull request #1137:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r685784529
##########
File path: libminifi/include/core/FlowFile.h
##########
@@ -310,6 +311,10 @@ struct SpecialFlowAttribute {
static const std::string ALTERNATE_IDENTIFIER;
// Flow identifier
static const std::string FLOW_ID;
+
+ static std::unordered_set<std::string> getSpecialFlowAttributes() {
+ return {PATH, ABSOLUTE_PATH, FILENAME, UUID, priority, MIME_TYPE,
DISCARD_REASON, ALTERNATE_IDENTIFIER, FLOW_ID};
+ }
Review comment:
I'm not sure it's a good idea as there are currently 69 occurrences of
the `SpecialFlowAttribute` in the codebase and it would take a lot of changes.
My other problem with it is that the main use case of the
`SpecialFlowAttribute`s is using them as strings while getting or setting
attributes so the enums would always have to be converted to strings which
would make their usage harder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
