[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1137: MINIFICPP-1607 Add AttributesToJson processor

Mon, 16 Aug 2021 08:13:58 -0700 


adamdebreceni commented on a change in pull request #1137:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r689626001



##########
File path: libminifi/test/TestBase.h
##########
@@ -164,6 +165,31 @@ class LogTestController {
     return found;
   }
 
+  std::optional<std::smatch> matchesRegex(const std::string &regex_str,

Review comment:
       as this is a single use function, it would be better IMO if we moved it 
into the `AttributesToJSONTests.cpp` if possible, thus other test wouldn't have 
to parse `<regex>` (or move the impl to the `TestBase.cpp` and return a 
`vector<string>`, but that would sacrifice some semantic power in the name of 
build-time)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to